Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update and unify expandToViewport API documentation #1383

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

timogasda
Copy link
Member

@timogasda timogasda commented Jul 27, 2023

Description

Update expandToViewport documentation to be more clear.

Related links, issue #, if available: AWSUI-21409,STUtACqqlwLT

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@timogasda timogasda requested a review from a team as a code owner July 27, 2023 13:55
@timogasda timogasda requested review from gethinwebster and removed request for a team July 27, 2023 13:55
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a9c0b7) 93.48% compared to head (a79d040) 93.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         624      624           
  Lines       16796    16796           
  Branches     5558     5558           
=======================================
  Hits        15701    15701           
  Misses       1022     1022           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timogasda timogasda merged commit da6bf84 into main Jul 27, 2023
24 checks passed
@timogasda timogasda deleted the gasda/expandtoviewport-docs branch July 27, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants