Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove /internal/i18n in favor of /i18n #1382

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Jul 27, 2023

Description

Okay, so... everyone we asked to use /internal/i18n before we released it has switched out to /i18n. Let's nip this tech debt in the bud.

Most of it is path updates. The only meaningful changes are under build-tools and src/internal/i18n (now gone).

Related links, issue #, if available: n/a

How has this been tested?

Existing tests should pass. Also manually inspected the built messages to make sure everything checked out.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8d643d6) 93.46% compared to head (6db2cc4) 93.47%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files         623      624    +1     
  Lines       16764    16778   +14     
  Branches     5547     5550    +3     
=======================================
+ Hits        15669    15683   +14     
  Misses       1022     1022           
  Partials       73       73           
Files Changed Coverage Δ
src/alert/internal.tsx 100.00% <ø> (ø)
src/app-layout/index.tsx 93.49% <ø> (ø)
src/area-chart/elements/use-highlight-details.ts 100.00% <ø> (ø)
src/attribute-editor/row.tsx 96.66% <ø> (ø)
src/autosuggest/autosuggest-option.tsx 86.95% <ø> (ø)
src/autosuggest/internal.tsx 96.05% <ø> (ø)
src/breadcrumb-group/internal.tsx 86.84% <ø> (ø)
src/calendar/internal.tsx 98.07% <ø> (ø)
src/cards/index.tsx 93.90% <ø> (ø)
src/code-editor/index.tsx 96.50% <ø> (ø)
... and 53 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot marked this pull request as ready for review July 27, 2023 10:27
@avinashbot avinashbot requested a review from a team as a code owner July 27, 2023 10:27
@avinashbot avinashbot requested review from abdhalees and removed request for a team July 27, 2023 10:27
@avinashbot avinashbot merged commit 51c36a3 into main Jul 27, 2023
27 checks passed
@avinashbot avinashbot deleted the i18n-remove-internal branch July 27, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants