Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix README basic example #1370

Merged

Conversation

maroKanatani
Copy link
Contributor

@maroKanatani maroKanatani commented Jul 26, 2023

Description

Hello, thanks for this useful software !

I copied and ran the basic example in the README and got an error.

Parsing error: Unexpected token, expected "("

I think there should be () after the JavaScript function.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@maroKanatani maroKanatani requested a review from a team as a code owner July 26, 2023 01:50
@maroKanatani maroKanatani requested review from connorlanigan and removed request for a team July 26, 2023 01:50
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (67ea10c) 93.46% compared to head (a13ca59) 93.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         623      623           
  Lines       16764    16764           
  Branches     5547     5547           
=======================================
  Hits        15669    15669           
  Misses       1022     1022           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorlanigan connorlanigan merged commit b2a00e1 into cloudscape-design:main Jul 26, 2023
22 of 24 checks passed
@connorlanigan
Copy link
Member

Hi!
Good catch, thank you for spotting this and submitting the PR! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants