Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include Wizard header in step context #1368

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

connorlanigan
Copy link
Member

Description

Before this PR, the header area of the Wizard component was not included in the step context. This meant that when an info link inside the header was clicked, the resulting helpPanelInteracted event did not contain information about the current step.

This PR moves the step context so that it contains the whole content area of the Wizard (i.e. without the navigation on the side).

Related links, issue #, if available: n/a

How has this been tested?

Tested manually in dev page by inspecting the generated event

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (ea832bb) 93.48% compared to head (9bdd99a) 93.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1368      +/-   ##
==========================================
- Coverage   93.48%   93.47%   -0.02%     
==========================================
  Files         624      623       -1     
  Lines       16801    16770      -31     
  Branches     5552     5546       -6     
==========================================
- Hits        15707    15676      -31     
  Misses       1021     1021              
  Partials       73       73              
Files Changed Coverage Δ
src/wizard/wizard-form.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connorlanigan connorlanigan merged commit a5f00e6 into main Jul 27, 2023
24 checks passed
@connorlanigan connorlanigan deleted the funnel/wizard-header-in-step-context branch July 27, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants