Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Mark Cards component as a funnel substep #1362

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

connorlanigan
Copy link
Member

@connorlanigan connorlanigan commented Jul 24, 2023

Description

After this change, the Cards component is treated as a substep when it comes to funnel metrics, i.e. it is treated like a container.

Related links, issue #, if available: n/a

How has this been tested?

Extended the unit test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@connorlanigan connorlanigan marked this pull request as ready for review July 24, 2023 14:19
@connorlanigan connorlanigan requested a review from a team as a code owner July 24, 2023 14:19
@connorlanigan connorlanigan requested review from avinashbot and removed request for a team July 24, 2023 14:19
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5f2f70c) 93.48% compared to head (8c3418b) 93.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         624      624           
  Lines       16797    16797           
  Branches     5549     5549           
=======================================
  Hits        15703    15703           
  Misses       1021     1021           
  Partials       73       73           
Impacted Files Coverage Δ
src/cards/index.tsx 93.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@connorlanigan connorlanigan merged commit c2af2a6 into main Jul 24, 2023
25 checks passed
@connorlanigan connorlanigan deleted the funnel/cards-as-substep branch July 24, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants