Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add totalSubSteps property and funnelStepError event #1354

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

connorlanigan
Copy link
Member

Description

This PR adds the new event funnelStepError, which is used to emit a metric about an error that relates to a whole step, usually an Alert outside of a container. It differs from funnelSubStepError, which is for errors inside a substep like a container, and from funnelError, which is more generic.

Related links, issue #, if available: CR-97002073

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@connorlanigan connorlanigan requested a review from a team as a code owner July 20, 2023 13:38
@connorlanigan connorlanigan requested review from just-boris and removed request for a team July 20, 2023 13:38
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0df2a92) 93.46% compared to head (c480128) 93.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         623      623           
  Lines       16733    16733           
  Branches     5527     5527           
=======================================
  Hits        15639    15639           
  Misses       1021     1021           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@just-boris just-boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I need to understand the context better.

This PR adds events but they are never called. Is this coming in the future PRs?

@connorlanigan
Copy link
Member Author

This PR adds events but they are never called. Is this coming in the future PRs?

Yes. There will be a separate PR to call the new funnelStepError event, and another PR to calculate the value for totalSubSteps.

@connorlanigan connorlanigan merged commit 66fc217 into main Jul 21, 2023
24 checks passed
@connorlanigan connorlanigan deleted the chore/metrics-types branch July 21, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants