Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix focus outline on app layout triggers #1353

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Jul 20, 2023

Description

Fixing a regression introduced in #1343

Related links, issue #, if available: n/a

How has this been tested?

  • Locally
  • Tests in my dev pipeline
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner July 20, 2023 13:32
@just-boris just-boris requested review from pan-kot and removed request for a team July 20, 2023 13:32
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0df2a92) 93.46% compared to head (0fb24f9) 93.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         623      623           
  Lines       16733    16733           
  Branches     5527     5527           
=======================================
  Hits        15639    15639           
  Misses       1021     1021           
  Partials       73       73           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@just-boris just-boris merged commit d85259a into main Jul 20, 2023
26 checks passed
@just-boris just-boris deleted the fix-classic-drawers branch July 20, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants