Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore focus to custom popover triggers #1352

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

gethinwebster
Copy link
Member

Description

Ensure that if a custom popover trigger is used, the focus is returned
to it when the popover is dismissed.

Related links, issue #, if available: AWSUI-21509

How has this been tested?

New integ tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c8425e8) 93.46% compared to head (9394858) 93.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         623      623           
  Lines       16733    16736    +3     
  Branches     5527     5530    +3     
=======================================
+ Hits        15639    15642    +3     
  Misses       1021     1021           
  Partials       73       73           
Impacted Files Coverage Δ
src/popover/internal.tsx 93.33% <100.00%> (+0.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gethinwebster gethinwebster requested review from a team, jperals and rubencarvalho and removed request for johannes-weber, a team and jperals July 21, 2023 09:30
Copy link
Contributor

@rubencarvalho rubencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gethinwebster gethinwebster merged commit 1095782 into main Jul 24, 2023
24 checks passed
@gethinwebster gethinwebster deleted the popover-custom-focus branch July 24, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants