From 1dac34a4f2c66084debd73dfc4d75369d03a2e40 Mon Sep 17 00:00:00 2001
From: Avinash Dwarapu <dwaraa@amazon.com>
Date: Thu, 27 Jul 2023 17:01:50 +0200
Subject: [PATCH] Call getMatchableLocales in importMessages

---
 build-tools/tasks/generate-i18n-messages.js | 30 ++++++++++++---------
 src/i18n/dynamic.d.ts                       |  5 ++++
 src/i18n/get-matchable-locales.ts           | 15 +++++++++++
 src/i18n/provider.tsx                       | 14 +---------
 4 files changed, 39 insertions(+), 25 deletions(-)
 create mode 100644 src/i18n/get-matchable-locales.ts

diff --git a/build-tools/tasks/generate-i18n-messages.js b/build-tools/tasks/generate-i18n-messages.js
index cca2958e32..bf16217914 100644
--- a/build-tools/tasks/generate-i18n-messages.js
+++ b/build-tools/tasks/generate-i18n-messages.js
@@ -51,26 +51,32 @@ module.exports = function generateI18nMessages() {
 
   // Generate a dynamic provider function for automatic bundler splitting and imports.
   const dynamicFile = [
-    `import { warnOnce } from '@cloudscape-design/component-toolkit/internal';`,
-    `import { isDevelopment } from '../internal/is-development';\n`,
-    `export function importMessages(locale) {`,
-    `  switch (locale.toLowerCase()) {`,
+    `import { warnOnce } from '@cloudscape-design/component-toolkit/internal';
+import { isDevelopment } from '../internal/is-development';
+import { getMatchableLocales } from './get-matchable-locales';
+
+export function importMessages(locale) {
+  for (const matchableLocale of getMatchableLocales(locale)) {
+    switch (matchableLocale.toLowerCase()) {`,
     ...files.flatMap(fileName => {
       const [subset, locale] = fileName.split('.');
       if (subset !== 'all') {
         return []; // For now, this only supports loading all messages for the locale.
       }
       return [
-        `  case "${locale.toLowerCase()}":`,
-        `    return import("./messages/${subset}.${locale}.js").then(mod => [mod.default]);`,
+        `    case "${locale.toLowerCase()}":
+      return import("./messages/${subset}.${locale}.js").then(mod => [mod.default]);`,
       ];
     }),
-    `  }\n`,
-    `  if (isDevelopment) {`,
-    `    warnOnce('importMessages', \`Unknown locale "\${locale}" provided to importMessages\`)`,
-    `  }\n`,
-    `  return Promise.resolve([]);`,
-    `}`,
+    `    }
+  }
+
+  if (isDevelopment) {
+    warnOnce('importMessages', \`Unknown locale "\${locale}" provided to importMessages\`)
+  }
+
+  return Promise.resolve([]);
+}`,
   ].join('\n');
 
   fs.copyFileSync(path.join(sourceI18nDir, 'dynamic.d.ts'), path.join(targetI18nDir, 'dynamic.d.ts'));
diff --git a/src/i18n/dynamic.d.ts b/src/i18n/dynamic.d.ts
index ff0372bf62..95c8f690ee 100644
--- a/src/i18n/dynamic.d.ts
+++ b/src/i18n/dynamic.d.ts
@@ -1,4 +1,9 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
+
+// It's fine for importMessages to raise TypeScript requirements because
+// it will usually be accompanied by the I18nProvider anyway.
+// eslint-disable-next-line @cloudscape-design/ban-files
 import { I18nProviderProps } from './provider';
+
 export function importMessages(locale: string): Promise<ReadonlyArray<I18nProviderProps.Messages>>;
diff --git a/src/i18n/get-matchable-locales.ts b/src/i18n/get-matchable-locales.ts
new file mode 100644
index 0000000000..c22069a368
--- /dev/null
+++ b/src/i18n/get-matchable-locales.ts
@@ -0,0 +1,15 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+export function getMatchableLocales(ietfLanguageTag: string): string[] {
+  const parts = ietfLanguageTag.split('-');
+  if (parts.length === 1) {
+    return [ietfLanguageTag];
+  }
+
+  const localeStrings: string[] = [];
+  for (let i = parts.length; i > 0; i--) {
+    localeStrings.push(parts.slice(0, i).join('-'));
+  }
+  return localeStrings;
+}
diff --git a/src/i18n/provider.tsx b/src/i18n/provider.tsx
index b02d8da062..4d8cf2e2bc 100644
--- a/src/i18n/provider.tsx
+++ b/src/i18n/provider.tsx
@@ -9,6 +9,7 @@ import { warnOnce } from '@cloudscape-design/component-toolkit/internal';
 import { useTelemetry } from '../internal/hooks/use-telemetry';
 import { applyDisplayName } from '../internal/utils/apply-display-name';
 import { InternalI18nContext, FormatFunction, CustomHandler } from './context';
+import { getMatchableLocales } from './get-matchable-locales';
 
 export interface I18nProviderProps {
   messages: ReadonlyArray<I18nProviderProps.Messages>;
@@ -137,16 +138,3 @@ function mergeMessages(sources: ReadonlyArray<I18nProviderProps.Messages>): I18n
   }
   return result;
 }
-
-function getMatchableLocales(ietfLanguageTag: string): string[] {
-  const parts = ietfLanguageTag.split('-');
-  if (parts.length === 1) {
-    return [ietfLanguageTag];
-  }
-
-  const localeStrings: string[] = [];
-  for (let i = parts.length; i > 0; i--) {
-    localeStrings.push(parts.slice(0, i).join('-'));
-  }
-  return localeStrings;
-}