Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the splunk-otel-java-agent framework. #968

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Introduce the splunk-otel-java-agent framework. #968

merged 4 commits into from
Dec 13, 2022

Conversation

breedx-splk
Copy link
Contributor

This framework will wire up the Splunk distribution of OpenTelemetry java for auto-instrumentation and direct ingest. It leverages VCAP_SERVICES and the existence of a service binding with a specific name (splunk-o11y).

Signed-off-by: Jason Plumb [email protected]

Resolves issue #825

@breedx-splk
Introduce the splunk-otel-java-agent framework.
7c46b1d 
This framework will wire up the splunk distribution of opentelemetry java for auto-instrumentation and direct ingest. It leverages VCAP_SERVICES and the existence of a service binding with a specific name (splunk-o11y).

Signed-off-by: Jason Plumb [email protected]

Resolves issue cloudfoundry#825
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 19, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: breedx-splk / name: jason plumb (7c46b1d)

@breedx-splk breedx-splk mentioned this pull request Sep 28, 2022
Open
dmikusa
dmikusa reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, much appreciated! A few bits of feedback.

docs/framework-splunk_otel_java_agent.md Outdated Show resolved Hide resolved
docs/framework-splunk_otel_java_agent.md Outdated Show resolved Hide resolved
lib/java_buildpack/framework/splunk_otel_java_agent.rb Show resolved Hide resolved
@breedx-splk
Copy link
Contributor Author

Thanks @dmikusa for the review...greatly appreciated. I made some changes and am ready for another look.

@breedx-splk
Copy link
Contributor Author

Hi @dmikusa Just checking back in after a few days. Thanks.

@dmikusa
Copy link
Contributor

dmikusa commented Oct 11, 2022

Apologizes. I don't have access to CF environments at the moment. @pivotal-david-osullivan would need to provide final review & merge.

@breedx-splk
Copy link
Contributor Author

Hi @pivotal-david-osullivan any chance to get a review on this please? 🙏🏻

@pivotal-david-osullivan
Copy link
Contributor

Apologies for the delay, I had some issues getting environments too, I will review and update ASAP!

@breedx-splk
Copy link
Contributor Author

@pivotal-david-osullivan Just touching base again. 🤞🏻 Thanks.

@breedx-splk
Copy link
Contributor Author

Nudging this again to keep this alive.....thanks in advance.

@breedx-splk
Copy link
Contributor Author

Maybe we could get a look before the year is over?

@pivotal-david-osullivan pivotal-david-osullivan merged commit b6e55e5 into cloudfoundry:main Dec 13, 2022
@pivotal-david-osullivan
Copy link
Contributor

I was able to get a lab and test this, the agent downloads and I see some initial output. Thank you for your patience on this @breedx-splk and thanks again for the PR, I've merged it in!

@breedx-splk breedx-splk mentioned this pull request Mar 29, 2023
Merged
@tylerbenson tylerbenson mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikusa dmikusa dmikusa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@breedx-splk @dmikusa @pivotal-david-osullivan