Remove vip usage #419
Remove vip usage #419
Conversation
|
I tried to claim a bosh lite but it seems to think there are none available. I left a message in the capi slack channel asking if I was just doing it wrong. I was able to create a bosh release with cloudfoundry/cloud_controller_ng#3761 but wasn't able to test if it deployed successfully due to the inability to claim a bosh lite. If someone else is able to give a whirl and run cats that would be helpful, or let me know how to correctly claim a bosh lite |
moleske
force-pushed
the
gh-3712-no-more-vip
branch
from
7210da3
to
935ea54
Compare
|
putting back in draft cause I got a bosh lite and failures. I wonder if it is because cf networking is still expecting something with vip |
moleske
force-pushed
the
gh-3712-no-more-vip
branch
from
935ea54
to
cd2d15b
Compare
|
see cloudfoundry/cloud_controller_ng#3761 (comment) for details |
| It is recommended to leave this value as the default. | ||
| If this range is changed, it is likely the routes on the internal service mesh domain | ||
| will need to be recreated." | ||
| description: "This is only here cause cf networking needs it, we should coordinate a delete with them" |
There was a problem hiding this comment.
@ameowlia @geofffranks why does cf-networking-release use this?
https://github.com/search?q=repo%3Acloudfoundry%2Fcf-networking-release%20internal_route_vip_range&type=code
There was a problem hiding this comment.
oh this was only needed for istio release stuff which was never GAed. rip it out.
There was a problem hiding this comment.
when you say rip it out, do you mean make prs to cf networking to remove internal_route_vip_range, followed by removing internal_route_vip_range here? Or do you mean merge this PR as is and some day in the future remove from internal_route_vip_range from cf networking and then from here?
moleske
force-pushed
the
gh-3712-no-more-vip
branch
from
cd2d15b
to
2d10ed9
Compare
|
Got this working on a bosh lite! cf acceptance test 16.4.0 is passing with the config generated. bosh lite is regent in the capi pool for those curious. Could use some reviews from folks, though probably need an answer from @ameowlia or @geofffranks about why cf networking needs vip before deciding to merge or not. Mostly cause if vip can be removed from cf networking, then we can remove it from here afterword (would be multiple major bumps in cf-d I believe) |
moleske
force-pushed
the
gh-3712-no-more-vip
branch
from
2d10ed9
to
f9766a5
Compare
- cf-networking-release expects a bosh link to consume for us, so we can actually remove the property til they stop wanting it - https://github.com/cloudfoundry/cf-networking-release/blob/a0b0fc7de7d3dd8564e3ab1fbb0f5b4f7e29791f/jobs/garden-cni/spec#L11-L13
moleske
force-pushed
the
gh-3712-no-more-vip
branch
from
f9766a5
to
ca66f08
Compare
|
Rip it out! do it! |
|
@ameowlia, thanks for the context! |
cloudfoundry/cloud_controller_ng#3712
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite