Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async_nats #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JT117
Copy link

@JT117 JT117 commented Jun 21, 2023

Add support for async_nats crate, pretty much a copy/paste of the nats integration part.
The async_nats Message does not implement Clone for now hence the 'manual' clone

@JT117 JT117 force-pushed the feat/add_support_async_nats branch from 7f1c2fe to a765e9a Compare September 8, 2023 12:34
Copy link

@ppiotr3k ppiotr3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just a potential future user of this async support, but spotted a fix needed in added doc in order for this to be functional 🙂

//! Serialize [Event](https://docs.rs/cloudevents-sdk/latest/cloudevents/event/struct.Event.html) into [NatsCloudEvent] and publish to nats subject
//! ```
//! use async_nats_lib as async_nats;
//! use cloudevents::binding::nats::NatsCloudEvent;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix needed in doc to use async bindings:

Suggested change
//! use cloudevents::binding::nats::NatsCloudEvent;
//! use cloudevents::binding::async_nats::NatsCloudEvent;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants