Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide AMQP 1.0 binding with fe2o3-amqp #188

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Provide AMQP 1.0 binding with fe2o3-amqp #188

wants to merge 31 commits into from

Conversation

minghuaw
Copy link
Contributor

This PR implements AMQP 1.0 binding. A working example is also provided.

@minghuaw
impl conversion btwn AmqpMessage & AmqpCloudEvent
24c30b5 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
implemented From<Event> for AmqpCloudEvent
8b7e2a2 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
added udf to handle extensions
4017ffc 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
initial impl of deserializers
e516489 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
removed unused imports
64693d1 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
removed AmqpCloudEvent
f9b5058 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
Revert "removed AmqpCloudEvent"
73e1f62 
This reverts commit 1214976.

Signed-off-by: minghuaw <[email protected]>
@minghuaw
replace format with header_prefix
90f84e3 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
impl From<AmqpMessage> for AmqpCloudEvent
73ff402 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
renamed to AmqpBinding
6e90ddb 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
renamed to EventMessage
508976c 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
removed prefix from extension name
832098c 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
added amqp example
3d835a6 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
removed unused type alias
880da69 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
fixed example
b193012 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
treat missing cloutEvents prefix as extension
55c5c8f 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
prefix extension values like standard attr values
8739e9d 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
updated example
22a88e8 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
added assertions in example
1188f17 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
updated docs
f7d3b86 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
updated mod level doc
c26131f 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
updated mod level doc
c477db4 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
cargo fmt
d8df9c0 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
fixed cargo fmt check and clippy warnings
2ab34e4 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
Show feature gated bindings in documentaion (cloudevents#187)
730b94e 
* show feature gated bindings in docsrs

* moved crate root docsrs feature

* fixed cargo fmt check

* removed files that should go with another PR

Signed-off-by: minghuaw <[email protected]>
@minghuaw
fixed doctest
0436209 
Signed-off-by: minghuaw <[email protected]>
@minghuaw
cargo fix --all && cargo fmt --all
f623f15 
Signed-off-by: minghuaw <[email protected]>
@jcrossley3
Copy link
Contributor

Hey, I'm sorry I've neglected this. I'm looking to cut a new release soon. Would you mind rebasing this and let me know if you think it's "release ready"? Thanks!

@minghuaw
Copy link
Contributor Author

minghuaw commented Nov 4, 2022

Thanks for asking. There have been some big changes in fe2o3-amqp and I haven't update this PR yet. So I would not consider this as "release ready". I will update the PR in the next couple days and will let you know when I think it is ready

@jcrossley3
Copy link
Contributor

Thanks for asking. There have been some big changes in fe2o3-amqp and I haven't update this PR yet. So I would not consider this as "release ready". I will update the PR in the next couple days and will let you know when I think it is ready

Cool. I may cut one before then and we'll get you in the next one, so no rush. Thanks for your contribution and patience! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minghuaw @jcrossley3