Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform workflow #55

Merged
merged 20 commits into from
Aug 7, 2023
Merged

Terraform workflow #55

merged 20 commits into from
Aug 7, 2023

Conversation

VishwajitNagulkar
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar commented Jul 24, 2023 •
edited
Loading

what

  • This terraform workflow generates an issue before the apply or destroy step with a required plan in it. If we comment "yes", "lgtm" the workflow will proceed to the next step. However, if we comment "deny," the workflow will be canceled.
  • Updated Readme documentation and added examples for aws, digitaloccean, azure and gcp

@VishwajitNagulkar VishwajitNagulkar requested a review from a team July 24, 2023 19:01
@VishwajitNagulkar VishwajitNagulkar changed the title Internal 357 Terraform workflow Jul 24, 2023
d4kverma
d4kverma approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmolnagpal anmolnagpal merged commit ee772b2 into master Aug 7, 2023
@anmolnagpal anmolnagpal deleted the internal_357 branch August 7, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@d4kverma d4kverma d4kverma approved these changes

@nikitadugar nikitadugar Awaiting requested review from nikitadugar

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VishwajitNagulkar @anmolnagpal @d4kverma