feat/prowler shared workflow for AWS and GCP #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bharadwajshivam28
requested review from
anmolnagpal and
clouddrove-ci
as code owners
.github/workflows/prowler.yml
Outdated
| secrets: | ||
| WIP: | ||
| required: false | ||
| description: 'WIP' |
There was a problem hiding this comment.
give proper description
.github/workflows/prowler.yml
Outdated
| token_format: access_token | ||
| workload_identity_provider: ${{ secrets.WIP }} | ||
| service_account: ${{ secrets.SERVICE_ACCOUNT }} | ||
| access_token_lifetime: 300s |
There was a problem hiding this comment.
Pass access_token_lifetime value in inputs and set default value
.github/workflows/prowler.yml
Outdated
| aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }} | ||
| role-to-assume: ${{ secrets.BUILD_ROLE }} | ||
| aws-region: ${{ inputs.aws_region }} | ||
| role-duration-seconds: 900 |
VishwajitNagulkar
approved these changes
Aug 12, 2024
AshutoshAM2002
approved these changes
Aug 13, 2024
anmolnagpal
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prowler workflow for GCP and AWS