Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for migrations/api.py module #317

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add unit tests for migrations/api.py module #317

merged 1 commit into from
Jun 4, 2024

Conversation

mihaelabalutoiu
Copy link
Contributor

This PR adds test cases for coriolis/migrations/api.py module

ionutbalutoiu
ionutbalutoiu suggested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. The rest LGTM.

coriolis/tests/migrations/test_api.py Outdated Show resolved Hide resolved
coriolis/tests/migrations/test_api.py Show resolved Hide resolved
@Dany9966 Dany9966 merged commit f8941bf into cloudbase:master Jun 4, 2024
4 checks passed
@mihaelabalutoiu mihaelabalutoiu deleted the add-migrations-unit-tests branch June 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionutbalutoiu ionutbalutoiu ionutbalutoiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaelabalutoiu @ionutbalutoiu @Dany9966