Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for coriolis.conductor.rpc.utils module #297

Merged
merged 1 commit into from
Mar 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 114 additions & 0 deletions coriolis/tests/conductor/rpc/test_utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
# Copyright 2024 Cloudbase Solutions Srl
# All Rights Reserved.

import time

from unittest import mock

from coriolis.conductor.rpc import utils as rpc_utils
from coriolis.tests import test_base
from coriolis import utils


class CoriolisTestException(Exception):
pass


class ConductorUtilsTestCase(test_base.CoriolisBaseTestCase):
"""Test suite for the Coriolis Conductor RPC utils."""

@mock.patch.object(utils, 'get_exception_details')
@mock.patch.object(time, 'sleep')
def test_check_create_registration_for_service(
self,
mock_sleep,
mock_get_exception_details
):
conductor_rpc = mock.Mock()
conductor_rpc.check_service_registered.return_value = {
'id': mock.sentinel.id}
result = rpc_utils.check_create_registration_for_service(
conductor_rpc,
mock.sentinel.request_context,
mock.sentinel.host,
mock.sentinel.binary,
mock.sentinel.topic,
enabled=False,
mapped_regions=None,
providers=mock.sentinel.providers,
specs=mock.sentinel.specs,
retry_period=30
)

self.assertEqual(
conductor_rpc.update_service.return_value,
result
)
conductor_rpc.check_service_registered.assert_called_once_with(
mock.sentinel.request_context,
mock.sentinel.host,
mock.sentinel.binary,
mock.sentinel.topic
)
conductor_rpc.update_service.assert_called_once_with(
mock.sentinel.request_context,
mock.sentinel.id,
updated_values={
"providers": mock.sentinel.providers,
"specs": mock.sentinel.specs
}
)
conductor_rpc.register_service.assert_not_called()
mock_sleep.assert_not_called()
mock_get_exception_details.assert_not_called()

@mock.patch.object(utils, 'get_exception_details')
@mock.patch.object(time, 'sleep')
def test_check_create_registration_for_service_register_service(
self,
mock_sleep,
mock_get_exception_details
):
conductor_rpc = mock.Mock()
conductor_rpc.check_service_registered.side_effect = \
[CoriolisTestException(), None]
period = 30
with self.assertLogs('coriolis.conductor.rpc.utils', level='WARN'):
result = rpc_utils.check_create_registration_for_service(
conductor_rpc,
mock.sentinel.request_context,
mock.sentinel.host,
mock.sentinel.binary,
mock.sentinel.topic,
enabled=False,
mapped_regions=None,
providers=mock.sentinel.providers,
specs=mock.sentinel.specs,
retry_period=30
)

self.assertEqual(
conductor_rpc.register_service.return_value,
result
)
conductor_rpc.check_service_registered.assert_has_calls(
[mock.call(
mock.sentinel.request_context,
mock.sentinel.host,
mock.sentinel.binary,
mock.sentinel.topic
)] * 2
)
conductor_rpc.register_service.assert_called_once_with(
mock.sentinel.request_context,
mock.sentinel.host,
mock.sentinel.binary,
mock.sentinel.topic,
False,
mapped_regions=None,
providers=mock.sentinel.providers,
specs=mock.sentinel.specs
)
conductor_rpc.update_service.assert_not_called()
mock_sleep.assert_called_once_with(period)
mock_get_exception_details.assert_called_once()
Loading