Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add grep #24

Merged
merged 1 commit into from
Nov 20, 2023
Merged

add grep #24

merged 1 commit into from
Nov 20, 2023

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Add support for grep to image based on user request: #23 (comment)

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, these are well-understood CLI utilities that are being pulled from the upstream Alpine repository, which is updated frequently.

@markdboyd markdboyd requested a review from a team November 20, 2023 18:41
@markdboyd markdboyd mentioned this pull request Nov 20, 2023
Merged
@markdboyd markdboyd merged commit 389a839 into main Nov 20, 2023
1 check passed
@markdboyd markdboyd deleted the add-grep branch November 20, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMcGowan ChrisMcGowan ChrisMcGowan approved these changes

@mogul mogul mogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdboyd @mogul @ChrisMcGowan