From b37f25e979ea3460afd87925a9937425732f9bd8 Mon Sep 17 00:00:00 2001 From: JChoy Date: Mon, 26 Aug 2024 14:46:34 +0900 Subject: [PATCH] fix: resolve todo; pop after hook --- src/libraries/hooks_list.cairo | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libraries/hooks_list.cairo b/src/libraries/hooks_list.cairo index 4ddda20..1ddf468 100644 --- a/src/libraries/hooks_list.cairo +++ b/src/libraries/hooks_list.cairo @@ -1,9 +1,9 @@ use starknet::{SyscallResultTrait, ContractAddress, syscalls, get_caller_address}; use starknet::storage::Map; -use openzeppelin_utils::structs::storage_array::{StorageArray, StorageArrayTrait}; use clober_cairo::utils::constants::ZERO_ADDRESS; use clober_cairo::libraries::hooks::{Hooks, HooksTrait, Permission}; use clober_cairo::libraries::book_key::BookKey; +use clober_cairo::libraries::storage_array::{StorageArray, StorageArrayTrait}; use clober_cairo::interfaces::book_manager::{MakeParams, TakeParams, CancelParams}; pub type HooksList = StorageArray; @@ -20,7 +20,7 @@ pub impl HooksListImpl of HooksListTrait { } fn get_hook(self: @HooksList, i: u32) -> ContractAddress { - self.read_at(i) + self.read_at(i.into()) } fn call_hook( @@ -35,8 +35,7 @@ pub impl HooksListImpl of HooksListTrait { let selector = Serde::::deserialize(ref res).unwrap(); // @dev Clear current hook here - // TODO: check this - // self.hooks_list.pop(); + self.pop(); assert(selector == expected_selector, 'InvalidHookResponse'); }