chore(package.json): prevent publishing via NPM #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
prepublishOnlyscript to prevent publishing via NPM.prepublishOnlyscripts are called by NPM before publish whennpm publishis called. These scripts are ignored by Yarn, allowing us to callyarn npm publishas intended.Motivation and Context
Publishing via
npm publishdoes not resolveworkspace:protocols independencies, which leads to an error when our users try to install our packages.Technically, this change is not necessary for
joint-core(since it does not have anyworkspace:protocol dependencies), but I did it for it too for consistency.