Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust center position of new scale wrt previous scale, not 1. #1375

Closed
wants to merge 1 commit into from
Closed

Adjust center position of new scale wrt previous scale, not 1. #1375

wants to merge 1 commit into from

Conversation

avshenuk
Copy link

@avshenuk avshenuk commented Oct 4, 2020

Tested locally and this now works correctly.
A simple example: if you're already on scale 2, and trying to set the scale to 2 again, simply glancing through the previous code, you can see that it will move the origin when it shouldn't at all.

@kumilingus
Copy link
Contributor

Hi @avshenuk, thank you! This looks good. I just need to test whether it is a breaking change or not.

@github-actions
Copy link

github-actions bot commented May 6, 2022

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label May 6, 2022
@kumilingus kumilingus added this to the v4.0 milestone May 6, 2022
@kumilingus kumilingus removed the stale This issue/PR shows no activity for an extended period of time. label May 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Jul 6, 2022
@kumilingus kumilingus added technical debt and removed stale This issue/PR shows no activity for an extended period of time. labels Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Sep 5, 2022
@jamesgeorgewilliams jamesgeorgewilliams removed the stale This issue/PR shows no activity for an extended period of time. label Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Nov 5, 2022
@kumilingus kumilingus removed the stale This issue/PR shows no activity for an extended period of time. label Nov 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Jan 5, 2023
@kumilingus kumilingus removed the stale This issue/PR shows no activity for an extended period of time. label Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Mar 7, 2023
@jamesgeorgewilliams jamesgeorgewilliams removed the stale This issue/PR shows no activity for an extended period of time. label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented May 7, 2023

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label May 7, 2023
@kumilingus kumilingus removed the stale This issue/PR shows no activity for an extended period of time. label May 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Jul 7, 2023
@kumilingus kumilingus removed the stale This issue/PR shows no activity for an extended period of time. label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Sep 6, 2023
@github-actions github-actions bot closed this Sep 20, 2023
@kumilingus kumilingus reopened this Sep 20, 2023
@github-actions github-actions bot removed the stale This issue/PR shows no activity for an extended period of time. label Sep 21, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Nov 20, 2023
@jamesgeorgewilliams jamesgeorgewilliams removed the stale This issue/PR shows no activity for an extended period of time. label Nov 20, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Please remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale This issue/PR shows no activity for an extended period of time. label Jan 20, 2024
@kumilingus kumilingus mentioned this pull request Jan 20, 2024
Merged
@kumilingus kumilingus removed the stale This issue/PR shows no activity for an extended period of time. label Jan 22, 2024
@kumilingus
Copy link
Contributor

Sorry for the delay. It is a breaking fix and it was addressed here: #2495
Thanks for pointing that out.

@kumilingus kumilingus closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@avshenuk @kumilingus @jamesgeorgewilliams