Use upstream needle #43
Comments
wearhere
added a commit
to mixmaxhq/blessed
that referenced
this issue
Jul 22, 2019
To avoid forcing clients to reference this dependency from GitHub, for reasons similar to clearbit/clearbit-node#43.
wearhere
added a commit
to mixmaxhq/node-tail
that referenced
this issue
Jul 22, 2019
To avoid forcing clients to reference this dependency from GitHub, for reasons similar to clearbit/clearbit-node#43. We can _almost_ switch back to the upstream, which has merged most of our changes, but is missing one feature lucagrulla#64 (comment).
wearhere
added a commit
to mixmaxhq/custody
that referenced
this issue
Jul 25, 2019
For reasons similar to clearbit/clearbit-node#43. We have to update `react-blessed` as well because that loads `blessed` as a peer dependency. We don’t have to fork the library to load `@mixmaxhq/blessed` as a peer dependency instead, luckily, since a more recent version of `react-blessed` adds support for injecting a `blessed` instance. It appears that this more recent version and/or the use of `createBlessedRenderer` fixes the issue where `react-blessed` automatically suppresses the project exiting, too (see that we are now able to import the library outside `start` without e.g. preventing `custody-cli -h` from exiting). Fixes https://mixmaxhq.atlassian.net/browse/MX-7481.
|
This is causing issues for me with yarn also. |
|
Looks like they never went ahead in doing this. If you are still dealing with this issue see my workaround here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like the clearbit client is using a forked copy of
needlefor browserify support: clearbit/needle#1. Upstreamneedleadded this support in tomas/needle#146, so can the client use the upstream version ofneedleto avoid thesenpmerrors?The text was updated successfully, but these errors were encountered: