-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add Prism Tile #247
Comments
fyi I am workin on this feature |
@evansmj Hey Michael how is your progress coming along? Would be happy to review when you think its ready |
hey @johngribbin, we got a quick demo for our hackathon. I need to clean up some alignments and make the prism detail part look more like rest of the app. we did get a prism icon from a designer (need to size it better). here are some preliminary screenshots. if you have design feedback that would be great and i could match whatever you like. A prism tile will be shown only if the plugins list rpc command says the prisms plugin is installed. it renders before Settings so that settings remains the last tile. The prism portal will show a list of prisms, and a list of offers. A user will be able to Bind a prism to an existing offer here. I show the list of offers here so that all prism related code remains in the prism portal. I haven't figured out the ux for setting a Binding yet. Now if you click on a prism it will show the prism details. This layout is up in the air and I think i should match offers/channels. The prism detail reflects this json
prism bindings will reflect this data.
Somewhere i need to figure out a place to show existing Bindings. Maybe this should be separate from the offers list. Any design ideas would be great else I'll keep working with Farscapian to create it. Oh and i still need to make the Create a prism page and a Delete/Disable prism mechanism somewhere. |
Just going to throw this out there after chatting about this topic with a few folks. It would be preferable to make the prism-binding stuff be centered around BOLT12 Offers in the UI. That is, the place you go to bind a prism and to view binding outlays would be Top Menu -> Offers. @evansmj I know this contradicts what I told you during the hackathon, but in speaking with @johngribbin , it may make sense to keep that stuff under Offers (the prism-related stuff under Offers would still be contingent on plugin-list). Keep in mind binding stuff is keyed on offer_id in the Prism API/db. So in term of UI, on on the Menu -> Prism, replace the "Offers" Section (on the lower half) with a button or link that states "Manage Bindings" that links you to Menu -> Offers. When a user clicks an offer, they will see the prism_id if any prism bound to the offer. When creating a binding, the UI will display a list of Prism_ids, of which one (and only one) prism can be selected. |
Also, prism-bindinglist has been updated to the following format, per feedback from this integration. binding_id is for UI purposes only, but wondering if I can remove it now assuming we put this stuff under Menu->Offers. {
"bolt12_prism_bindings": [
{
"binding_id": "c4a16493a362a111f8491251b74dfceb4fb511970ddf3147fe9d51fb29d2dd7c",
"offer_id": "8ca1b3674a2f39f00fd7f1b01e148b37bbc3146f1fe872e84ed615647a850ee2",
"prism_id": "prism1",
"timestamp": 1716209712,
"member_outlays": [
{
"member_id": "073a5853-8744-464e-a353-cc5018a01cfc",
"outlay_msat": "0"
},
{
"member_id": "403d8edb-5c66-4af2-b8bd-28831f315d18",
"outlay_msat": "0"
},
{
"member_id": "7f01e3fd-6a80-466d-84a6-bda144a9283e",
"outlay_msat": "0"
}
]
}
]
}
|
Sounds good on moving the bindings to the offers. for binding_id i think yes you could remove it since i will latch these bindings onto existing offer_ids |
Hey @farscapian I am working on this now. Will drop any Qs I have here for discussion as I work through the feature. |
@johngribbin , you're the man. pulling @sbddesign, who expressed interest in the project, into the conversation. |
The BOLT12 Prism plugin has undergone additional development and is reaching a stable state. Assuming the prism plugin is installed, Clams Remote should allow a node owner to create and manage prisms by surfacing a "Prism" tile. The UI should also enable the node operator to attach a prism to a BOLT12 offer and enable prism payment via
prism-pay
.@evansmj
The text was updated successfully, but these errors were encountered: