Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.12 support #665

Closed
cjkrolak opened this issue Oct 16, 2023 · 3 comments
Closed

python 3.12 support #665

cjkrolak opened this issue Oct 16, 2023 · 3 comments
Labels
enhancement New feature or request Priority-3 lowest priority, no commit date on fix

Comments

@cjkrolak
Copy link
Owner

initial testing, aiohttp is not yet supported in python 3.12
@cjkrolak cjkrolak added enhancement New feature or request Priority-3 lowest priority, no commit date on fix labels Oct 16, 2023
@cjkrolak
Copy link
Owner Author

aiohttp 3.9.0b0 is required for python 3.12-support. This library is used by blinkpy. ref: aio-libs/aiohttp#7739

@cjkrolak
Copy link
Owner Author

sht31 server is unreachable due to network error, disabling

@cjkrolak
Copy link
Owner Author

python 3.12 testing passes with aiohttp update listed above except 2 issues:
camera list empty driveway - 5 failures
sht31 server unreachable.

======================================================================
ERROR: test_supervise (tests.test_blink_integration.SuperviseIntegrationTest.test_supervise)
Verify supervisor loop on target thermostat.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\cjkro\AppData\Local\Programs\Python\Python312\Lib\unittest\mock.py", line 1387, in patched
    return func(*newargs, **newkeywargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\github\ThermostatSupervisor\tests\unit_test_common.py", line 349, in test_supervise
    self.Thermostat, self.Zone = self.setup_thermostat_zone()
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\github\ThermostatSupervisor\tests\unit_test_common.py", line 234, in setup_thermostat_zone
    self.Thermostat, self.Zone = tc.create_thermostat_instance(
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\github\ThermostatSupervisor\thermostatsupervisor\thermostat_common.py", line 1097, in create_thermostat_instance
    Thermostat.print_all_thermostat_metadata(zone)
  File "C:\github\ThermostatSupervisor\thermostatsupervisor\blink.py", line 175, in print_all_thermostat_metadata
    self.exec_print_all_thermostat_metadata(
  File "C:\github\ThermostatSupervisor\thermostatsupervisor\thermostat_common.py", line 65, in exec_print_all_thermostat_metadata
    return_data = func(*args)
                  ^^^^^^^^^^^
  File "C:\github\ThermostatSupervisor\thermostatsupervisor\blink.py", line 139, in get_all_metadata
    return self.get_metadata(zone, None, debug)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\github\ThermostatSupervisor\thermostatsupervisor\blink.py", line 153, in get_metadata
    raise ValueError("camera list is empty when searching for camera"
ValueError: camera list is empty when searching for camera driveway

----------------------------------------------------------------------
Ran 130 tests in 414.687s

FAILED (errors=5, skipped=43)
--------------------------------------------------------------------------------
skipped tests(43):
test_humidity_repeatability (tests.test_blink_integration.PerformanceIntegrationTest.test_humidity_repeatability) performance integration tests are disabled
test_network_timing (tests.test_blink_integration.PerformanceIntegrationTest.test_network_timing) performance integration tests are disabled
test_temperature_repeatability (tests.test_blink_integration.PerformanceIntegrationTest.test_temperature_repeatability) performance integration tests are disabled
test_humidity_repeatability (tests.test_emulator_integration.PerformanceIntegrationTest.test_humidity_repeatability) performance integration tests are disabled
test_network_timing (tests.test_emulator_integration.PerformanceIntegrationTest.test_network_timing) performance integration tests are disabled
test_temperature_repeatability (tests.test_emulator_integration.PerformanceIntegrationTest.test_temperature_repeatability) performance integration tests are disabled
test_humidity_repeatability (tests.test_honeywell_integration.PerformanceIntegrationTest.test_humidity_repeatability) performance integration tests are disabled
test_network_timing (tests.test_honeywell_integration.PerformanceIntegrationTest.test_network_timing) performance integration tests are disabled
test_temperature_repeatability (tests.test_honeywell_integration.PerformanceIntegrationTest.test_temperature_repeatability) performance integration tests are disabled
test_humidity_repeatability (tests.test_kumocloud_integration.PerformanceIntegrationTest.test_humidity_repeatability) performance integration tests are disabled
test_network_timing (tests.test_kumocloud_integration.PerformanceIntegrationTest.test_network_timing) performance integration tests are disabled
test_temperature_repeatability (tests.test_kumocloud_integration.PerformanceIntegrationTest.test_temperature_repeatability) performance integration tests are disabled
test_a_thermostat_basic_checkout (tests.test_kumolocal_integration.FunctionalIntegrationTest.test_a_thermostat_basic_checkout) kumolocal tests are disabled
test_get_all_meta_data (tests.test_kumolocal_integration.FunctionalIntegrationTest.test_get_all_meta_data) kumolocal tests are disabled
test_get_meta_data (tests.test_kumolocal_integration.FunctionalIntegrationTest.test_get_meta_data) kumolocal tests are disabled
test_report_heating_parameters (tests.test_kumolocal_integration.FunctionalIntegrationTest.test_report_heating_parameters) kumolocal tests are disabled
test_humidity_repeatability (tests.test_kumolocal_integration.PerformanceIntegrationTest.test_humidity_repeatability) kumolocal tests are disabled
test_network_timing (tests.test_kumolocal_integration.PerformanceIntegrationTest.test_network_timing) kumolocal tests are disabled
test_temperature_repeatability (tests.test_kumolocal_integration.PerformanceIntegrationTest.test_temperature_repeatability) kumolocal tests are disabled
test_supervise (tests.test_kumolocal_integration.SuperviseIntegrationTest.test_supervise) kumolocal tests are disabled
test_a_thermostat_basic_checkout (tests.test_mmm_integration.FunctionalIntegrationTest.test_a_thermostat_basic_checkout) mmm tests are disabled
test_get_all_meta_data (tests.test_mmm_integration.FunctionalIntegrationTest.test_get_all_meta_data) mmm tests are disabled
test_get_meta_data (tests.test_mmm_integration.FunctionalIntegrationTest.test_get_meta_data) mmm tests are disabled
test_report_heating_parameters (tests.test_mmm_integration.FunctionalIntegrationTest.test_report_heating_parameters) mmm tests are disabled
test_thermostat_get_ui_data (tests.test_mmm_integration.FunctionalIntegrationTest.test_thermostat_get_ui_data) mmm tests are disabled
test_thermostat_get_ui_data_param (tests.test_mmm_integration.FunctionalIntegrationTest.test_thermostat_get_ui_data_param) mmm tests are disabled
test_zone_get_zone_name (tests.test_mmm_integration.FunctionalIntegrationTest.test_zone_get_zone_name) mmm tests are disabled
test_humidity_repeatability (tests.test_mmm_integration.PerformanceIntegrationTest.test_humidity_repeatability) mmm tests are disabled
test_network_timing (tests.test_mmm_integration.PerformanceIntegrationTest.test_network_timing) mmm tests are disabled
test_temperature_repeatability (tests.test_mmm_integration.PerformanceIntegrationTest.test_temperature_repeatability) mmm tests are disabled
test_supervise (tests.test_mmm_integration.SuperviseIntegrationTest.test_supervise) mmm tests are disabled
test_sht31_flask_server (tests.test_sht31_flask_server.IntegrationTest.test_sht31_flask_server) sht31 tests are disabled
test_sht31_flask_server_all_pages (tests.test_sht31_flask_server.IntegrationTest.test_sht31_flask_server_all_pages) sht31 tests are disabled
test_a_thermostat_basic_checkout (tests.test_sht31_integration.FunctionalIntegrationTest.test_a_thermostat_basic_checkout) sht31 tests are disabled
test_get_all_meta_data (tests.test_sht31_integration.FunctionalIntegrationTest.test_get_all_meta_data) sht31 tests are disabled
test_get_meta_data (tests.test_sht31_integration.FunctionalIntegrationTest.test_get_meta_data) sht31 tests are disabled
test_report_heating_parameters (tests.test_sht31_integration.FunctionalIntegrationTest.test_report_heating_parameters) sht31 tests are disabled
test_humidity_repeatability (tests.test_sht31_integration.PerformanceIntegrationTest.test_humidity_repeatability) sht31 tests are disabled
test_network_timing (tests.test_sht31_integration.PerformanceIntegrationTest.test_network_timing) sht31 tests are disabled
test_temperature_repeatability (tests.test_sht31_integration.PerformanceIntegrationTest.test_temperature_repeatability) sht31 tests are disabled
test_supervise (tests.test_sht31_integration.SuperviseIntegrationTest.test_supervise) sht31 tests are disabled
test_supervisor_flask_server (tests.test_supervisor_flask_server.IntegrationTest.test_supervisor_flask_server) this test hangs when run from the command line
test_thermostat_basic_checkout (tests.test_thermostat_common.Test.test_thermostat_basic_checkout) sht31 tests are disabled
--------------------------------------------------------------------------------
Name                                              Stmts   Miss  Cover
---------------------------------------------------------------------
tests\test_blink_integration.py                      38     10    74%
tests\test_email_notification.py                     61      5    92%
tests\test_emulator_integration.py                   37     11    70%
tests\test_environment.py                            70      3    96%
tests\test_honeywell_integration.py                  36     11    69%
tests\test_kumocloud_integration.py                  36     11    69%
tests\test_kumolocal_integration.py                  39     22    44%
tests\test_mmm_integration.py                        52     32    38%
tests\test_sht31_flask_server.py                     79     57    28%
tests\test_sht31_integration.py                      38     20    47%
tests\test_supervise.py                              19      2    89%
tests\test_supervisor_flask_server.py                60     36    40%
tests\test_thermostat_api.py                         71      5    93%
tests\test_thermostat_common.py                     249     46    82%
tests\test_utilities.py                             204      3    99%
tests\unit_test_common.py                           383     59    85%
thermostatsupervisor\__init__.py                      1      0   100%
thermostatsupervisor\blink.py                       167     88    47%
thermostatsupervisor\blink_config.py                 21      0   100%
thermostatsupervisor\email_notification.py           63      2    97%
thermostatsupervisor\emulator.py                    177     15    92%
thermostatsupervisor\emulator_config.py              14      0   100%
thermostatsupervisor\environment.py                 108     19    82%
thermostatsupervisor\flask_generic.py                30      9    70%
thermostatsupervisor\honeywell.py                   254     66    74%
thermostatsupervisor\honeywell_config.py              7      0   100%
thermostatsupervisor\kumocloud.py                   235     50    79%
thermostatsupervisor\kumocloud_config.py             12      0   100%
thermostatsupervisor\kumolocal.py                   198    145    27%
thermostatsupervisor\kumolocal_config.py             12      0   100%
thermostatsupervisor\mmm.py                         271    200    26%
thermostatsupervisor\mmm_config.py                   10      0   100%
thermostatsupervisor\sht31.py                       181    136    25%
thermostatsupervisor\sht31_config.py                 58      3    95%
thermostatsupervisor\sht31_flask_server.py          298    160    46%
thermostatsupervisor\supervise.py                    45      7    84%
thermostatsupervisor\supervisor_flask_server.py      65     31    52%
thermostatsupervisor\thermostat_api.py              132     16    88%
thermostatsupervisor\thermostat_common.py           448     71    84%
thermostatsupervisor\utilities.py                   283     34    88%
---------------------------------------------------------------------
TOTAL                                              4562   1385    70%

cjkrolak added a commit that referenced this issue Oct 28, 2023
@cjkrolak
Merge pull request #669 from cjkrolak/665_python312_support
0c5c59f 
resolves #665 updating default python to 3.12
@cjkrolak cjkrolak mentioned this issue Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Priority-3 lowest priority, no commit date on fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjkrolak