Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing firewall multiple times keeps showing different and incorrect networks #448

Open
fernando-villalba opened this issue Aug 8, 2024 · 4 comments

Comments

@fernando-villalba
Copy link
Contributor

Issue

If you keep listing firewalls multiple times with

civo fw ls

You will see that the network keeps changing and it's not correct

Acceptance Criteria

  • Ensure the correct network is listed.
  • Make the order deterministic
@Praveen005
Copy link
Contributor

Hi @fernando-villalba

I couldn't re-create the first issue. I tried making firewalls with unique networks, multiple firewalls with same network, all the firewalls with default network.
But civo fw ls gave me correct result every time.
Am I getting it wrong?

Screenshot 2024-08-12 231840

As for making the order deterministic, I sorted the firewalls by ID and it solves the issue.

Screenshot 2024-08-12 221037

@Praveen005
Copy link
Contributor

Hi @uzaxirr,

This needs your attention too.

I tested again and the first part I couldn't recreate, to me it shows correct networks attached to their respective firewalls.

For the second part, sorting the slice of firewalls by ID, makes the order deterministic.

Thank you!

@uzaxirr
Copy link
Member

uzaxirr commented Sep 5, 2024

hey @Praveen005 even i tried and was not able to reproduce the error

@Praveen005
Copy link
Contributor

Maybe the issue has been fixed on the API side, because I tried several times over the past few days. Should I raise the PR for the second part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants