Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker improvements #192

Open
gurkanindibay opened this issue Sep 30, 2021 · 0 comments
Open

Publish Docker improvements #192

gurkanindibay opened this issue Sep 30, 2021 · 0 comments

Comments

@gurkanindibay
Copy link
Contributor

gurkanindibay commented Sep 30, 2021

  • Build & Tag and publish logic should be seperated and should be used as seperated steps in pipelines
  • github_ref parameter should be parsed and used as meaningful business paramters in the code.This parametter should not be used as input parameter for internal methods
  • All of the messages for the build should be printed even if build is successful
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant