Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkCreateSynchronisedScene improvements #922

Closed
wants to merge 1 commit into from

Conversation

ByRabeh099
Copy link

Improvements:

  • Added more detailed return value.
  • Added a simple example and a link to a more complex example.

netScene id
Network scene handle. This can be used to start / stop it and add peds or entities to it.

## Examples:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples cannot have a colon (:).

Comment on lines +47 to +48
## Advanced example
You can find an advanced example [here](https://pastebin.com/masLVdm5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be on the description, above parameters section. Also, 'double hash' (##) custom headers like these are not allowed, but 'triple hash' headers are. (###), so ideally ### Advanced example.

It's also somewhat discouraged to use pastebin links since they can expire/get removed, causing the research to be lost.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, however, some changes are needed. Please follow the guidelines outlined in CONTRIBUTING.md.

Thank you 🙂

Comment on lines +31 to +32
local pedCo = GetEntityCoords(ped)
local sceneObject = GetClosestObjectOfType(pedCo, 2.0, GetEntityModel('prop_weed_01'), false, false, false)
Copy link
Contributor

@4mmonium 4mmonium Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, I think changing pedCo to pedCoords would be better for readability here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to change everything you just told me

@ByRabeh099 ByRabeh099 closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants