Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zoned date time parsing #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wsargent
Copy link

Fixes #99

@orende
Copy link
Contributor

orende commented Apr 28, 2023

@wsargent Good catch! It feels like this behavior (date parsing) should have been caught by a test before merge. Could you add a test for this? Either a unit test or Selenium test, whichever you prefer.

@orende orende self-requested a review April 29, 2023 05:52
@wsargent
Copy link
Author

This is a bit of a problem, because the admin selenium test doesn't work for me. This is straight from HEAD on the master branch:

[ERROR] Failures:
[ERROR]   AdminAcceptanceTest.adminSiteCanBookNewCargo:53
Expecting:
 <"01/06/2023">
to be equal to:
 <"31/05/2023">
but was not.

I think the problem is that I'm in San Francisco and some of the timezone logic is hardcoded for another timezone...

@orende
Copy link
Contributor

orende commented Feb 23, 2024

This is a bit of a problem, because the admin selenium test doesn't work for me. This is straight from HEAD on the master branch:

[ERROR] Failures:
[ERROR]   AdminAcceptanceTest.adminSiteCanBookNewCargo:53
Expecting:
 <"01/06/2023">
to be equal to:
 <"31/05/2023">
but was not.

I think the problem is that I'm in San Francisco and some of the timezone logic is hardcoded for another timezone...

Sorry about the late reply to this, parental leave got in the way. We'll have to look into the hardcoded timezone and address it so that you can get the tests to pass.

@orende
Copy link
Contributor

orende commented Apr 2, 2024

@wsargent Could you rebase this pull request on master now and see if the changes from #136 fixes the test failures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date parsing failure when assigning cargo to route
2 participants