Fix build issues on STM32H7 with ARM GNU toolchain #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried building the libstrp for STM32H743ZI (Cortex-M7) target using ARM GNU GCC and faced some build issues. This change fixes those issues. 1. aes_gcm_mbedtls.c and aes_icm_mbedtls.c - Fix use for before declaration errors. 2. datatypes.h - Do not generate error when HAVE_NETINET_IN_H and HAVE_WINSOCK2_H are not defined. This enables the library to be used on embedded targets using FreeRTOS-Plus-TCP. 3. err.h and srtp.c - Allow the application to change the logging macro definitions at compile time. The application can provide these definitions in config.h. Signed-off-by: Gaurav Aggarwal <[email protected]>
|
I can understand 1 & 2, but why 3? You can install a handler for the debug, why do you need to replace at compile time. |
It is needed if I want to completely remove the debug logs to reduce code size. With this change I can add the following to config.h to remove logs - #define debug_print0(mod, format)
#define debug_print(mod, format, arg)
#define debug_print2(mod, format, arg1, arg2) |
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
|
@pabuhler Do you need anything else to merge this? |
pabuhler
approved these changes
Jul 16, 2024
|
Would be happy to fix if and when that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried building the libstrp for STM32H743ZI (Cortex-M7) target using ARM GNU GCC and faced some build issues. This change fixes those issues.
aes_gcm_mbedtls.candaes_icm_mbedtls.c- Fix use for before declaration errors.datatypes.h- Do not generate error whenHAVE_NETINET_IN_HandHAVE_WINSOCK2_Hare not defined. This enables the library to be used on embedded targets using FreeRTOS-Plus-TCP.err.handsrtp.c- Allow the application to change the logging macro definitions at compile time. The application can provide these definitions inconfig.h.