tetra: various dump processcache cmd improvements #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
the
release-note/misc
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I realized we used camelCase in a tetra subcmd and in the debug API. Changing the debug API should not be a problem as it was not yet released and it's a debug feature. The subcmd has an alias because it was easy. Signed-off-by: Mahe Tardy <[email protected]>
This allows the command to return != 0 return error code on failure as expected. Signed-off-by: Mahe Tardy <[email protected]>
When dumping a full process cache (around 65K entries) the gRPC client could not handle a response of this size. This makes it possible to configure it on demand if needed. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/process-cache-dump-fixes
branch
from
0b03e9a
to
b9d39bf
Compare
tpapagian
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for 0b03e9a, the rest was piggybacked by this.