Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: CRD version check fails on PRs from forks #2255

Closed
lambdanis opened this issue Mar 25, 2024 · 1 comment · Fixed by #2319
Closed

ci: CRD version check fails on PRs from forks #2255

lambdanis opened this issue Mar 25, 2024 · 1 comment · Fixed by #2319
Labels
area/ci Related to CI kind/bug Something isn't working

Comments

@lambdanis
Copy link
Contributor

lambdanis commented Mar 25, 2024 •
edited
Loading

The CRD version check fails on PRs from forks that modify CRDs with:

fatal: bad revision 'origin/<branch in the fork>'
Error: Process completed with exit code 128.

Examples: #2231, #2065
@lambdanis lambdanis added kind/bug Something isn't working area/ci Related to CI labels Mar 25, 2024
@kkourt kkourt mentioned this issue Apr 9, 2024
Merged
@kkourt
Copy link
Contributor

kkourt commented Apr 9, 2024

Checked t hat the issue was fixed in #2320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci Related to CI kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate-crd: use SHAs for diff cilium/tetragon
2 participants
@kkourt @lambdanis