Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check only updated docs links in PRs #2233

Closed
lambdanis opened this issue Mar 17, 2024 · 0 comments · Fixed by #2259
Closed

ci: Check only updated docs links in PRs #2233

lambdanis opened this issue Mar 17, 2024 · 0 comments · Fixed by #2259
Assignees
Labels
area/ci Related to CI kind/bug Something isn't working

Comments

@lambdanis
Copy link
Contributor

The CI job checking if links in docs are available is run both as a cron and on PRs updating docs. On PRs it checks all links, not only those added/modified in the PR. This means that if there is a known broken link, CI fails on unrelated PRs updating docs.

Example:

  1. Cron job found a broken link and opened an issue: Documentation: broken links automatic report #2209
  2. CI on unrelated policyfilter: Apply Policy Only to Specific Containers in a Pod #2231 failed because of this link: https://github.com/cilium/tetragon/actions/runs/8315157105/job/22754113804?pr=2231

The CI job running on PRs should fail only if one of the links added/modified in the PR is unavailable, and ignore other broken links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Related to CI kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants