Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error with SMB_INSECURE_SERVER enabled #615

Open
makseto opened this issue Aug 11, 2024 · 1 comment
Open

Compile error with SMB_INSECURE_SERVER enabled #615

makseto opened this issue Aug 11, 2024 · 1 comment

Comments

@makseto
Copy link

makseto commented Aug 11, 2024

I’ve tried to compile latest released ksmbd version 3.5.0 for vanilla linux LTS kernel 6.6.44 with SMB_INSECURE_SERVER=y (SMBv1 support needed). The following errors occurred during compilation:

fs/smb/server/smb1pdu.c:` In function 'smb_rename':
fs/smb/server/smb1pdu.c:862:14: error: implicit declaration of function 'ksmbd_vfs_kern_path'; did you mean 'ksmbd_vfs_zero_data'? [-Werror=implicit-function-declaration]
  862 |         rc = ksmbd_vfs_kern_path(work, newname, LOOKUP_NO_SYMLINKS, &path, 1);
      |              ^~~~~~~~~~~~~~~~~~~
      |              ksmbd_vfs_zero_data
fs/smb/server/smb1pdu.c:887:14: error: implicit declaration of function 'ksmbd_vfs_fp_rename'; did you mean 'ksmbd_vfs_rename'? [-Werror=implicit-function-declaration]
  887 |         rc = ksmbd_vfs_fp_rename(work, fp, newname);
      |              ^~~~~~~~~~~~~~~~~~~
      |              ksmbd_vfs_rename

I see that there is conditional compilation for different kernel versions in many places (#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 4, 0)), even two different smb2_rename functions.
But not in/for smb_rename().

@namjaejeon
Copy link
Member

@mmakassikis Haven't you faced this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants