Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows does not support uglify. It only runs with the -r switch. #16

Open
blargism opened this issue Mar 13, 2013 · 2 comments
Open

Windows does not support uglify. It only runs with the -r switch. #16

blargism opened this issue Mar 13, 2013 · 2 comments
Assignees

Comments

@blargism
Copy link
Contributor

Here's the error. If I add the -r switch it compiles and watches just fine.

The command that fails
handlebar-rider -i ".\templates" -o ".\templates.js" -w

Environment
Windows 8 nodejs command prompt version 0.8.16

Error
at new JS_Parse_Error (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\n
ode_modules\uglify-js\lib\parse-js.js:260:22)
at js_error (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_module
s\uglify-js\lib\parse-js.js:268:15)
at parse_error (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_mod
ules\uglify-js\lib\parse-js.js:359:17)
at hex_bytes (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_modul
es\uglify-js\lib\parse-js.js:418:33)
at read_escaped_char (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\no
de_modules\uglify-js\lib\parse-js.js:407:59)
at C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_modules\uglify-j
s\lib\parse-js.js:445:51
at with_eof_error (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_
modules\uglify-js\lib\parse-js.js:581:32)
at read_string (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_mod
ules\uglify-js\lib\parse-js.js:425:24)
at Object.next_token [as input](C:UsersJoeAppDataRoamingnpmnode_moduleshandleb
ar-ridernode_modulesuglify-jslibparse-js.js:596:52)
at next (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_modules\ug
lify-js\lib\parse-js.js:706:37)
at subscripts (C:\Users\Joe\AppData\Roaming\npm\node_modules\handlebar-rider\node_modu
les\uglify-js\lib\parse-js.js:1169:25)

@ghost ghost assigned piercemoore Mar 13, 2013
@piercemoore
Copy link
Collaborator

I am on this issue, this is actually my boss at work and not a random internet stranger. We found this bug today and I asked him to log it.

Commit 028b299 fixed the Windows directory separator bug, but it turns out that UglifyJS has WAY more issues than that. It just doesn't want to run properly. So I'm going to dig a bit and check it out.

@blargism
Copy link
Contributor Author

I'm guessing it has to do with directory separators as well. I think the suggestion of just disabling uglify on windows is a good one for the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants