Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an MLEM solver #20

Merged
merged 19 commits into from
Dec 9, 2023
Merged

Add an MLEM solver #20

merged 19 commits into from
Dec 9, 2023

Conversation

lesaintjerome
Copy link
Contributor

@lesaintjerome lesaintjerome commented Jul 7, 2023 •
edited by Obi-Wan
Loading

Description

Standard MLEM solver.

TODO

  • Implement new feature.
  • Add or update unittests.
  • Add or update docstrings.

Notes

@Obi-Wan Obi-Wan added the enhancement New feature or request label Jul 8, 2023
@lesaintjerome
Copy link
Contributor Author

CI failed due to multiplication by x_mask without checking presence of it. Corrected in b8dd556

Obi-Wan
Obi-Wan reviewed Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@Obi-Wan Obi-Wan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good addition. There might be some minor points to fix. Thanks!

corrct/_projector_backends.py Outdated Show resolved Hide resolved
examples/example_10_synthetic_phantom_dead-zone_MLEM_vs_SIRT.py Outdated Show resolved Hide resolved
corrct/solvers.py Outdated Show resolved Hide resolved
corrct/solvers.py Outdated Show resolved Hide resolved
corrct/solvers.py Outdated Show resolved Hide resolved
corrct/solvers.py Outdated Show resolved Hide resolved
examples/example_10_synthetic_phantom_dead-zone_MLEM_vs_SIRT.py Outdated Show resolved Hide resolved
examples/example_10_synthetic_phantom_dead-zone_MLEM_vs_SIRT.py Outdated Show resolved Hide resolved
examples/example_10_synthetic_phantom_dead-zone_MLEM_vs_SIRT.py Outdated Show resolved Hide resolved
@Obi-Wan Obi-Wan added this to the Release v0.9 milestone Jul 25, 2023
Jerome Lesaint and others added 19 commits December 9, 2023 17:44
@Obi-Wan
Add MLEM solver
607741a
@Obi-Wan
Apply mask to current iterate
f117551
@Obi-Wan
Prevent div by 0 and handle prj_shape overriding in 2D
8cf8bea
@Obi-Wan
Add an example script MLEM vs SIRT
9051dac
@Obi-Wan
Clean example 10
df59556
@Obi-Wan
Regularized MLEM and WIP MLEM test
7b86be0
@Obi-Wan
Remove regul in MLEM
fda73fd
@Obi-Wan
Bug fix: check presence of x_mask
6712fa5
@Obi-Wan
Bug fix
8b3a7a8
@Obi-Wan
Review of the MLEM PR
53ba2e4
@Obi-Wan
Change docstring of example_10
68d0823
@Obi-Wan
Remove regul param
f0cb4a2
@Obi-Wan
Remove background noise from MLEM test
675c29a
@Obi-Wan
Fix plot
44fd942
@Obi-Wan
Added background support to MLEM
5f1592b 
Signed-off-by: Nicola VIGANO <[email protected]>
@Obi-Wan
MLEM: fixed reporting and residuals evaluation
15dee37 
Signed-off-by: Nicola VIGANO <[email protected]>
@Obi-Wan
MLEM: fixed example
e87ab49 
Signed-off-by: Nicola VIGANO <[email protected]>
@Obi-Wan
Fixed MLEM test, and added tolerance to verbose output
b568b66 
Signed-off-by: Nicola VIGANO <[email protected]>
@Obi-Wan
MLEM/example: updagred to Py3.9
c417300 
Signed-off-by: Nicola VIGANO <[email protected]>
@Obi-Wan Obi-Wan merged commit f615239 into cicwi:master Dec 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Obi-Wan Obi-Wan Obi-Wan left review comments

Assignees

@lesaintjerome lesaintjerome

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@lesaintjerome @Obi-Wan