Only list dependencies needed for library #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's only a few ways this library is used, and this change should not impact any of them. 1. Library for another tool: the devDependencies are not used. 2. Command-line client: the devDependencies are not used. 3. Local development: the devDependencies would be installed. 4. Automated tests: the devDependencies are installed. 5. Automated documentation: the devDependencies are installed. Pulling in this change will significantly reduce the number of dependencies when other people use markdown2confluence in their software. After: ``` ├── [email protected] ├─┬ [email protected] │ └── [email protected] └─┬ [email protected] └─┬ [email protected] └── [email protected] ``` Before: ``` ├─┬ [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ ├── [email protected] │ │ └─┬ [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ ├─┬ [email protected] │ │ │ ├── [email protected] │ │ │ └── [email protected] │ │ ├─┬ [email protected] │ │ │ └── [email protected] │ │ └─┬ [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├── [email protected] │ └─┬ [email protected] │ ├── [email protected] │ └── [email protected] ├── [email protected] ├─┬ [email protected] │ └─┬ [email protected] │ └── [email protected] ├── [email protected] └─┬ [email protected] ├── [email protected] ├── [email protected] ├── [email protected] ├─┬ [email protected] │ └── [email protected] ├── [email protected] ├─┬ [email protected] │ ├── [email protected] │ └── [email protected] ├── [email protected] ├─┬ [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ ├── [email protected] │ │ ├── [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ └─┬ [email protected] │ └── [email protected] ├─┬ [email protected] │ └── [email protected] ├── [email protected] ├─┬ [email protected] │ ├── [email protected] │ └─┬ [email protected] │ ├─┬ [email protected] │ │ └─┬ [email protected] │ │ ├─┬ [email protected] │ │ │ └── [email protected] │ │ ├── [email protected] │ │ ├─┬ [email protected] │ │ │ ├─┬ [email protected] │ │ │ │ └─┬ [email protected] │ │ │ │ ├── [email protected] │ │ │ │ ├── [email protected] │ │ │ │ └── [email protected] │ │ │ ├── [email protected] │ │ │ └── [email protected] │ │ ├─┬ [email protected] │ │ │ └── [email protected] │ │ ├─┬ [email protected] │ │ │ └── [email protected] │ │ ├── [email protected] │ │ ├── [email protected] │ │ ├── [email protected] │ │ ├── [email protected] │ │ ├─┬ [email protected] │ │ │ └─┬ [email protected] │ │ │ └── [email protected] │ │ ├─┬ [email protected] │ │ │ ├─┬ [email protected] │ │ │ │ ├── [email protected] │ │ │ │ └─┬ [email protected] │ │ │ │ └── [email protected] │ │ │ ├── [email protected] │ │ │ ├── [email protected] │ │ │ └── [email protected] │ │ └─┬ [email protected] │ │ ├── [email protected] │ │ └── [email protected] │ ├── [email protected] │ ├── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ ├─┬ [email protected] │ │ └── [email protected] │ └─┬ [email protected] │ └── [email protected] └─┬ [email protected] ├── [email protected] └── [email protected] ```
fidian
added a commit
to connected-world-services/markdown2confluence-cws
that referenced
this pull request
Mar 16, 2017
* Removes dependencies (min-util, min-qs). * Changes dev-only dependencies to devDependencies. chunpu#12 * Removes the website and browser builds. You can use wzrd.in to bundle automatically. chunpu#12 * Fixes nested lists. chunpu#11 chunpu#4 chunpu#3 * Fixes links to show the link text. chunpu#13 * Adds more newlines to ensure blocks work as expected. * Corrects tables. * Sets a default highlighting of "none" when no language is specified. * Command-line program can read from stdin. chunpu#10 * A pretty comprehensive suite of tests to ensure the library still works.
fidian
added a commit
to connected-world-services/markdown2confluence-cws
that referenced
this pull request
Mar 16, 2017
* Rebrand as markdown2confluence-cws. * Removes dependencies (min-util, min-qs). * Changes dev-only dependencies to devDependencies. chunpu#12 * Removes the website and browser builds. You can use wzrd.in to bundle automatically. chunpu#12 * Fixes nested lists. chunpu#11 chunpu#4 chunpu#3 * Fixes links to show the link text. chunpu#13 * Adds more newlines to ensure blocks work as expected. * Corrects tables. * Sets a default highlighting of "none" when no language is specified. * Command-line program can read from stdin. chunpu#10 * A pretty comprehensive suite of tests to ensure the library still works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only a few ways this library is used, and this change should not
impact any of them.
Pulling in this change will significantly reduce the number of
dependencies when other people use markdown2confluence in their
software.
After:
Before: