From 4ab08366242de35ffe6cd868bd764e19f03cf742 Mon Sep 17 00:00:00 2001
From: Christoph Lehmann <christoph.lehmann@networkteam.com>
Date: Thu, 14 Mar 2024 21:48:12 +0100
Subject: [PATCH] Better tab label for unknown elements

---
 Classes/Controller/WizardController.php     | 2 +-
 Resources/Private/Language/de.locallang.xlf | 8 ++++++++
 Resources/Private/Language/locallang.xlf    | 6 ++++++
 Resources/Private/Templates/Wizard.html     | 7 +++++--
 4 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/Classes/Controller/WizardController.php b/Classes/Controller/WizardController.php
index e5ecc9f..5a89670 100644
--- a/Classes/Controller/WizardController.php
+++ b/Classes/Controller/WizardController.php
@@ -264,7 +264,7 @@ protected function disableWizardsHavingNoResults(array $wizardItems): array
     protected function appendUnknownContentTypes(array $wizardItems): array
     {
         if ($this->unknownContentTypes !== [] && $this->getBackendUser()->isAdmin()) {
-            $wizardItems['unknown']['header'] = '?';
+            $wizardItems['unknown']['header'] = 'unknown';
             foreach ($this->unknownContentTypes as $no => $unknownContentType) {
                 $filterParts = [];
                 foreach ($unknownContentType as $fieldName => $fieldValue) {
diff --git a/Resources/Private/Language/de.locallang.xlf b/Resources/Private/Language/de.locallang.xlf
index cee9692..7ddd88e 100644
--- a/Resources/Private/Language/de.locallang.xlf
+++ b/Resources/Private/Language/de.locallang.xlf
@@ -15,6 +15,14 @@
 				<source>Records</source>
 				<target>Datensätze</target>
 			</trans-unit>
+			<trans-unit id="wizard_tab_unknown" resname="wizard_tab_unknown">
+				<source>Unknown</source>
+				<target>Unbekannte Elemente</target>
+			</trans-unit>
+			<trans-unit id="wizard_tab_unknown_description" resname="wizard_tab_unknown_description">
+				<source>These elements could not be displayed, are typically outdated and should be edited.</source>
+				<target>Diese Elemente können nicht dargestellt werden, sind typischerweise veraltet und sollten bearbeitet werden.</target>
+			</trans-unit>
 			<trans-unit id="wizard_error_message" resname="wizard_error_message">
 				<source>Nothing found. Probably the page id was configured incorrectly.</source>
 				<target>Nichts gefunden. Wahrscheinlich ist die Seiten-Id falsch konfiguriert.</target>
diff --git a/Resources/Private/Language/locallang.xlf b/Resources/Private/Language/locallang.xlf
index 3042595..04cb37d 100644
--- a/Resources/Private/Language/locallang.xlf
+++ b/Resources/Private/Language/locallang.xlf
@@ -12,6 +12,12 @@
 			<trans-unit id="wizard_tab_records" resname="wizard_tab_records">
 				<source>Records</source>
 			</trans-unit>
+			<trans-unit id="wizard_tab_unknown" resname="wizard_tab_unknown">
+				<source>Unknown elements</source>
+			</trans-unit>
+			<trans-unit id="wizard_tab_unknown_description" resname="wizard_tab_unknown_description">
+				<source>These elements could not be displayed, are typically outdated and should be edited.</source>
+			</trans-unit>
 			<trans-unit id="wizard_error_message" resname="wizard_error_message">
 				<source>Nothing found. Probably the page id was configured incorrectly.</source>
 			</trans-unit>
diff --git a/Resources/Private/Templates/Wizard.html b/Resources/Private/Templates/Wizard.html
index a4af2ba..8c90b8e 100644
--- a/Resources/Private/Templates/Wizard.html
+++ b/Resources/Private/Templates/Wizard.html
@@ -15,8 +15,11 @@
             <ul class="nav nav-tabs t3js-tabs" role="tablist" id="tabs-{tabsMenuId}" data-store-last-tab="1">
                 <f:for each="{tabsMenuItems}" as="item" iteration="iteration">
                     <li role="presentation" class="t3js-tabmenu-item nav-item">
-                        <a href="#{tabsMenuId}-{iteration.cycle}" class="nav-link {f:if(condition: '{iteration.cycle} == 1', then: ' active')}" aria-controls="{tabsMenuId}-{iteration.cycle}" role="tab" data-bs-toggle="tab">
-                            {item.label}
+                        <a href="#{tabsMenuId}-{iteration.cycle}" class="nav-link {f:if(condition: '{iteration.cycle} == 1', then: ' active')}" aria-controls="{tabsMenuId}-{iteration.cycle}" role="tab" data-bs-toggle="tab" title="{f:if(condition: '{item.label} == \'unknown\'', then: '{f:translate(key: \'wizard_tab_unknown_description\', extensionName: \'pagetreefilter\')}')}">
+                            <f:if condition="{item.label} == 'unknown'">
+                                <f:then><f:translate key="wizard_tab_unknown" extensionName="pagetreefilter"/> <core:icon identifier="actions-exclamation-triangle" alternativeMarkupIdentifier="inline" /></f:then>
+                                <f:else>{item.label}</f:else>
+                            </f:if>
                         </a>
                     </li>
                 </f:for>