Once a rule is suppressed, it remains as shown in current document

[gep13]

Steps to reproduce:

1. Open document with all rules active
2. Open settings and suppress a rule, for example CHOCO0001
3. Notice that squiggly line for that rule is still present
4. Close/open VSCode again, and rule violation will no longer be shown

As a result of changing suppressed rules, I think we need to clear the current diagnostics, and resubmit them. There is code for doing this in @tintoy repository for MSBuild Diagnostic Handler, so may be able to lean on what was done there.

[tintoy]

Hi - I’m about to go to bed (am in Australia), but will have a proper look at this tomorrow morning :)

[tintoy]

From what I remember, you send all diagnostics for a given document each time. So all diagnostics for a given document URI replace any existing diagnostics for that document URI. Does that help?

[tintoy]

(i.e. if there are no no diagnostics, send an empty list of diagnostics for that document)

[AdmiringWorm]

@tintoy I would say that the problem is more on how to get the diagnostics check to run again for the opened documents after the settings have been saved.

[gep13]

@AdmiringWorm this is sort of where I thought this would come in:

https://github.com/tintoy/msbuild-project-tools-server/blob/dbc74e841eb660826088e9cf94edb63f01631dd7/src/LanguageServer.Engine/Documents/Workspace.cs#L286-L298

i.e. once we know that the suppression rules have changed, clear the diagnostics out, and then run the checks again.

[tintoy]

@tintoy I would say that the problem is more on how to get the diagnostics check to run again for the opened documents after the settings have been saved.

My configuration handler has a hookable event which various other bits and pieces use to react to configuration changes. That might give you what you're after :)