Add a regex configration for the signal name style rule #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sconwayaus
force-pushed
the
signal_name_style_rule_regex
branch
4 times, most recently
from
ab3f53c
to
ab476aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
- Coverage 92.92% 92.92% -0.01%
==========================================
Files 359 359
Lines 26740 26768 +28
==========================================
+ Hits 24848 24874 +26
- Misses 1892 1894 +2 ☔ View full report in Codecov by Sentry. |
sconwayaus
force-pushed
the
signal_name_style_rule_regex
branch
3 times, most recently
from
fec2d4e
to
56359eb
Compare
sconwayaus
force-pushed
the
signal_name_style_rule_regex
branch
from
56359eb
to
c9db0ab
Compare
hzeller
reviewed
Jun 28, 2024
|
|
Did you check the review comment so far ? |
sconwayaus
commented
Jul 8, 2024
hzeller
reviewed
Jul 9, 2024
sconwayaus
force-pushed
the
signal_name_style_rule_regex
branch
from
c9db0ab
to
980355d
Compare
|
Thanks for your patience Henner. I've added regex's to most of the rules listed in #2074. I'll add your feedback from this PR into those and send on through. |
sconwayaus
force-pushed
the
signal_name_style_rule_regex
branch
from
980355d
to
fd79fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding regex configuration to the signal name style rule, part of issue #2074 .