Fix for property unquoting #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably need to merge #5 first to get CI run on this one. |
|
Do this need a rebase so it gets GitHub actions running? |
Waiting on review for #5 from @mithro and/or @HackerFoo |
litghost
reviewed
Dec 15, 2020
| @@ -243,8 +243,9 @@ def create_property_map(self, property_map, d): | |||
| entry.key = self.string_id(k) | |||
|
|
|||
| if isinstance(v, str): | |||
| if v[0] == '"' and v[-1] == '"': | |||
| v = v[1:-1] | |||
| if len(v) >= 2: | |||
There was a problem hiding this comment.
Can you add some unit tests around this code?
There was a problem hiding this comment.
Might be best to refactor the code first, and then write some tests on the separated function.
There was a problem hiding this comment.
This PR still needs some tests?
|
Please rebase |
… cause a crash. Signed-off-by: Maciej Kurc <[email protected]>
mkurc-ant
force-pushed
the
fix_empty_property
branch
from
a6d254b
to
2b981ec
Compare
kowalewskijan
pushed a commit
to antmicro/python-fpga-interchange
that referenced
this pull request
Apr 26, 2021
…_files Add CMake file to build static library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes property unquoting code. This allows storing empty properties instead of causing a crash.