Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test failures not detected. #39

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Fix unit test failures not detected. #39

merged 3 commits into from
Aug 25, 2023

Conversation

ReinderVosDeWael
Copy link
Contributor

@ReinderVosDeWael ReinderVosDeWael commented Aug 25, 2023

Failing unit tests were not resulting in a failing CI due to the output of pytest being piped. This PR resolves that, and also adds caching of poetry dependencies for faster CI :D.

The following changes were made:

  • Poetry install is now cached.
  • The unit test job will continue if it has a non-zero exit status.
  • Coverage has been moved into a separate job, which is dependent on the unit test job.

@ReinderVosDeWael ReinderVosDeWael self-assigned this Aug 25, 2023
@ReinderVosDeWael ReinderVosDeWael added the bug Something isn't working label Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Coverage

Coverage Report
FileStmtsMissCover
TOTAL100100%

Tests Skipped Failures Errors Time
4 0 💤 0 ❌ 0 🔥 0.070s ⏱️

@ReinderVosDeWael ReinderVosDeWael merged commit f335bc4 into main Aug 25, 2023
7 checks passed
@ReinderVosDeWael ReinderVosDeWael deleted the fix/testing branch August 25, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants