🧪 Update pre-commit-wrapped linters for Python 3.12 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/pylint-3.1.0
branch
5 times, most recently
from
21ebe61
to
bb861f3
Compare
|
pre-commit.ci run |
webknjaz
force-pushed
the
maintenance/pylint-3.1.0
branch
from
bb861f3
to
2e71f72
Compare
This version supports Python 3.12 officially. As a part of this patch, `pylint-pytest` is also updated with the bugfixes needed to stop capping it. An alpha version of the plugin is used due to a bug when running `pylint` in parallel mode [[1]]. [1]: pylint-dev/pylint-pytest#61
This is needed to support Python 3.12.
This seems to be necessary to support Python 3.12.
Otherwise, the formatter breaks f-strings.
webknjaz
force-pushed
the
maintenance/pylint-3.1.0
branch
from
2e71f72
to
539d13a
Compare
Flake8 runtime is now pinned to Python 3.11 in pre-commit since it explodes on Python 3.12 due to [[1]] currently. [1]: wemake-services/wemake-python-styleguide#2933
webknjaz
force-pushed
the
maintenance/pylint-3.1.0
branch
from
539d13a
to
28d79d5
Compare
webknjaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default runtime in pre-commit.ci got updated to Python 3.12, many checks started failing. This patch makes adjustments to the configuration to make it work again. They include bumping linter versions and pinning runtimes.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)N/A
❓ What is the current behavior? (You can also link to an open issue here)
pre-commit.ci is failing
❓ What is the new behavior (if this is a feature change)?
it doesn't
📋 Other information:
Looks like the service switched the default Python version to 3.12 which needs some config updates.
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is