Revert "Merge pull request #633 from cherrypy/debt/drop-py37" #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/py36
branch
from
b76c240
to
af1b867
Compare
The Python 3.6 runtime seems to be adding a trailing comma in the argument lists of class `repr()`s. This patch takes that into account in the regexes used in tests for checking what's logged.
The error is ```python-traceback ImportError: ../site-packages/cryptography/hazmat/bindings/_openssl.pypy36-pp73-x86_64-linux-gnu.so: undefined symbol: FIPS_mode ```
This is fine for a maintenance branch with older deps.
webknjaz
force-pushed
the
maintenance/py36
branch
from
59db134
to
7184939
Compare
webknjaz
force-pushed
the
maintenance/py36
branch
from
f6ea9df
to
78a5e42
Compare
This reverts commit 03926f3.
|
This is now a part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f82aee6, reversing changes made to 2b3b3eb.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)N/A
❓ What is the current behavior? (You can also link to an open issue here)
Python 3.6 and 3.7 are not tested in CI and are marked as unsupported in the metadata.
❓ What is the new behavior (if this is a feature change)?
Dropping Python 3.6/3.7 is reverted.
📋 Other information:
This is a check for whether the project can still run in the Python 3.6 runtime as needed by one of the downstream projects (Ceph). It is not intended to be merged into
mainbut may end up in a maintenance branch at some point, if I decide to keep a branch with backports for the 10.x stream.📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is