Tests failing when building locally (in typeguard) #680
Comments
|
Same error was reported in agronholm/typeguard#343. |
|
I do see that pytest==6.2.5 is getting installed. |
|
typeguard isn't being installed in CI, so that's probably why the issue isn't being encountered. I suspect typeguard is a recent dependency from inflect. CI is probably getting stale dependencies from somewhere. |
|
Typeguard is coming from the dependency on |
|
Question is - should cheroot work to unpin the dependency on older pytest or fix the issue with typeguard? |
|
pytest 6.2.5 is 2.5 years old. |
|
The pin mentions #511 |
|
Yes, pytest-forked is still unfixed: pytest-dev/pytest-forked#67. That's the reason pytest is old. I've was considering removing the use of this plugin but never got to figuring out if it can be replaced. I'm working towards making a stable v11.0.0 release (tried out the release pipeline through pre-release versions but the changelog needs to be polished a bit and then I'll release). Until it's released, I'd rather not add anything on top. Hoping to complete this in the next few days (ASAP really). |
That's the plan. |
|
To give some context, the reason there's constraint files is that I figured that I value stability of the CI and transparency of the pin updates over testing against the latest versions. This also makes it easier on the PR authors since it's more predictable and easier to separate failures caused by PRs vs. failures caused by the broken CI. Since I implemented it, the CI here is exceptionally stable. But such constraints are sometimes need restrictions when incompatibilities cause problems. Those constraints are meant to be temporary and should be removed as soon as a solution is found. Such old pins also start causing problems when other dependencies update and require newer versions of things. The recent example is #656 where upgrading |
|
@jaraco are you on x86_64 or ARM64? I suspect the latter. Currently, the lockfiles are only made for the former. So the |
|
Yes, ARM64 (macOS on Apple Silicon). |
|
@jaraco you can make symlinks for the constraint files using the pattern @ https://github.com/cherrypy/cheroot/blob/9d4de6b/bin/pip_constraint_helpers.py#L68 (you'll need to use what That's your immediate workaround. The deptree should be the same as for the x86_64 arch. I wish we could do this in CI properly but we'll have to wait until GH provides it to public. |
IIRC I wanted some sort of isolation since the test messes up with process-global things. That's my vague recollection, at least, I don't remember exactly. I also have a commit bit on that plugin repo but it's way too complicated for me to figure out by myself. |
This plugin is incompatible with Pytest 7+, it's difficult to fix upstream and there is no timeline for addressing that. The patch also bumps the top version boundary of Pytest to 7.2 due to the pinned `pytest-cov` raising warnings. Fixes #cherrypy#502 Resolves cherrypy#511 Closes cherrypy#680
This plugin is incompatible with Pytest 7+, it's difficult to fix upstream and there is no timeline for addressing that. The patch also bumps the top version boundary of Pytest to 7.2 due to the pinned `pytest-cov` raising warnings. Fixes #cherrypy#502 Resolves cherrypy#511 Closes cherrypy#680 Resolves cherrypy#681
When testing locally, I'm seeing this error:
I'm not sure why I'm not seeing the error in CI.
The text was updated successfully, but these errors were encountered: