Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin virtualization plugin: fix potential for false positive #1776

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Darwin virtualization plugin: fix potential for false positive #1776

merged 3 commits into from
Jan 19, 2023

Conversation

jweyer8
Copy link

@jweyer8 jweyer8 commented Dec 15, 2022

Description

Currently, a machine can be miscategorized as a physical machine. This can happen if a VM happens to have Parallels installed on it. This can be fixed by inverting the if-else statement, thereby checking if the machine is a VM before checking if the machine has Parallels installed on it.

Related Issue

#1775

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for [the Developer Certificate of Origin]

@jweyer8 jweyer8 requested review from a team as code owners December 15, 2022 00:59
@jweyer8 jweyer8 mentioned this pull request Dec 15, 2022
Open
@tpowell-progress tpowell-progress self-assigned this Dec 20, 2022
cookstyle changes
815d074 
Signed-off-by: Jared Weyer <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
13.4% 13.4% Duplication

tpowell-progress
tpowell-progress approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@tpowell-progress tpowell-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending test results.

@tpowell-progress tpowell-progress merged commit d72dac6 into chef:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress approved these changes

@jaymzh jaymzh jaymzh approved these changes

Assignees

@tpowell-progress tpowell-progress

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jweyer8 @jaymzh @tpowell-progress