Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the logic for control without results #8601

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YashviJain01
Copy link
Collaborator

@YashviJain01 YashviJain01 commented Sep 19, 2024

🔩 Description: What code changed, and why?

The CSV was not having controls where results array was not populated. Now, thw controls are added in cvs

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-9601

👍 Definition of Done

CSV and json have the same number of records now

👟 How to Build and Test the Change

  1. Add some compliance data
  2. Generate CSV and json both via UI
  3. Match the records

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

CSV and json file generated after the fix

2024-9-18 (1).csv
2024-9-18_new.json

Copy link

netlify bot commented Sep 19, 2024

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit d4e4210
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/66ebb333bb8da100093b7fc7

Quality Gate failed Quality Gate failed

Failed conditions
1 New issue

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant