Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang update patch #8557

Closed
wants to merge 22 commits into from
Closed

Golang update patch #8557

wants to merge 22 commits into from

Conversation

iamazzeez
Copy link
Contributor

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

daveaugustus added 13 commits August 29, 2024 13:16
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
@iamazzeez iamazzeez self-assigned this Aug 30, 2024
Copy link

netlify bot commented Aug 30, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit 1467511
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/66d6de03fabff20008394e2a

Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: iamazzeez <[email protected]>

Quality Gate failed Quality Gate failed

Failed conditions
5.0% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: iamazzeez <[email protected]>
@iamazzeez
Copy link
Contributor Author

#8590 this PR has changes.

@iamazzeez iamazzeez closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant