Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dependency protobuf not correctly specified #19

Closed
madonuko opened this issue Oct 30, 2023 · 1 comment · Fixed by #20
Closed

[BUG] Dependency protobuf not correctly specified #19

madonuko opened this issue Oct 30, 2023 · 1 comment · Fixed by #20

Comments

@madonuko
Copy link

madonuko commented Oct 30, 2023

Your crate is BROKEN

Your crate rust-criu does not have the correct dependency requirement for protobuf:
Cargo.toml:13:

protobuf = "3.2.0"

This is fatal as this WILL bring build errors on anything that depends on your crate once a newer version of protobuf is available.

Solution

Specify the version for protobuf exactly:

protobuf = "= 3.2.0"

and consider yanking previous versions of this crate. (All of them break anyway.)

And plus, now you can safely remove rust_criu_protobuf/rpc.rs:26 knowing that the protobuf version is definitely 3.2.0.

@MalteJ
Copy link

MalteJ commented Nov 9, 2024

@adrianreber may I ask you to release this change as a new crate version - maybe 0.4.1, so we can vendor it?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants