Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIU package for Ubuntu 24.04 #2404

Open
yang opened this issue May 18, 2024 · 14 comments
Open

CRIU package for Ubuntu 24.04 #2404

yang opened this issue May 18, 2024 · 14 comments
Assignees

Comments

@yang
Copy link

yang commented May 18, 2024

I saw that criu was removed from the Ubuntu 24's apt repos - is there another easy package based way to install on Ubuntu, or is build chain the only way from here on? Thanks.

https://launchpad.net/ubuntu/noble/amd64/criu/3.17.1-3

https://launchpad.net/~criu/+archive/ubuntu/ppa (no noble releases)

@mihalicyn
Copy link
Member

mihalicyn commented May 20, 2024

It's not removed from official Ubuntu repos, we just don't have PPA builds for Noble yet.

apt install criu should work just fine

Let me know if it does not work for you. I'll investigate this from Ubuntu side.

Upd: I have checked and can confirm problem. I'll try to figure out and come up with solution.

Thanks for reporting!

Upd 2: https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148

@mihalicyn mihalicyn self-assigned this May 20, 2024
@mihalicyn
Copy link
Member

Related to #2398

@rst0git
Copy link
Member

rst0git commented May 20, 2024

I will update the OBS/PPA packages with the workaround from #2398 (comment) for the time being and enable support for Ubuntu 24.04.

@mihalicyn
Copy link
Member

Huge thanks, Radostin!

I'll try to get CRIU into the official repos too. I was able to workaround compile-time failure, but there is another problem related to crit and python (see https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148).

@rst0git
Copy link
Member

rst0git commented May 20, 2024

Please avoid running setup.py and easy_install.

@mihalicyn Should be fixed by #2282

In addition, we have also applied the following patch in rst0git/criu-deb-packages@80ddb47

@rst0git
Copy link
Member

rst0git commented May 20, 2024

@yang I can confirm that Ubuntu 24.04 support has been enabled for the packages in OBS and PPA:

@mihalicyn
Copy link
Member

As I can see from https://launchpad.net/~criu/+archive/ubuntu/ppa/+packages we have no builds for Noble, but only for Jammy. I guess we need to change the last entry in debian/changelog file and specify noble in there.

I'm currently stuggling with this install-stage failure during binary package build:
https://launchpadlibrarian.net/730947573/buildlog_ubuntu-noble-amd64.criu_3.17.1-3ubuntu1_BUILDING.txt.gz

I have applied these patches:
7f0f075
rst0git/criu-deb-packages@80ddb47

but it looks like we need something in addition to make it work on Noble. Will continue investigation.

@rst0git
Copy link
Member

rst0git commented May 20, 2024

@mihalicyn Thanks for pointing this out! I've updated the release to noble in launchpad.

but it looks like we need something in addition to make it work on Noble. Will continue investigation.

dh_usrlocal: error: debian/criu/usr/local/bin/crit is not a directory
make: *** [debian/rules:9: binary] Error 25

There is a bug in the version of pip available on Ubuntu since 22.04. The pip install command does not take into account the value specified with --prefix when installing scripts (i.e., crit). This problem does not exist in earlier versions and it has fixed in newer versions of pip. As a workaround for this problem we use the following patch: rst0git/criu-deb-packages@e025b7e

@mihalicyn
Copy link
Member

mihalicyn commented May 21, 2024

Thanks @rst0git!

I have prepared a new debdiff:
https://bugs.launchpad.net/ubuntu/+source/criu/+bug/2066148/comments/5

hope it will be sponsored and uploaded. It is usually hard to get stable release packages updated.

@rst0git rst0git changed the title Removed from Ubuntu 24 apt CRIU package for Ubuntu 24.04 May 21, 2024
Copy link

A friendly reminder that this issue had no activity for 30 days.

@Brandl
Copy link

Brandl commented Sep 13, 2024

So has this been fixed? Is there a workaround?
I ran across this issue last week.

@avagin
Copy link
Member

avagin commented Sep 14, 2024

@rst0git do we have our repo with the up-to-date version?

@rst0git
Copy link
Member

rst0git commented Sep 14, 2024

do we have our repo with the up-to-date version?

yes.

@Brandl you can install the latest version of CRIU on Ubuntu 24.04 from Launchpad or OpenBuildService.

Copy link

A friendly reminder that this issue had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants