Feature/pimob 2191 upgrade kotlin compose and agp #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio-insolia-cko
force-pushed
the
feature/PIMOB-2191_Upgrade_kotlin_compose_and_agp
branch
from
0ca788d
to
cc8ec14
Compare
chintan-soni-cko
requested review from
deepesh-vasthimal-cko and
chintan-soni-cko
There was a problem hiding this comment.
We can also add test steps scenario from this Github issue part of PIMOB-2142 for this PR. So, we can close it once we release it
app/src/main/java/checkout/checkout_android/utils/PaymentUtil.java
Outdated
Show resolved
Hide resolved
fabio-insolia-cko
force-pushed
the
feature/PIMOB-2191_Upgrade_kotlin_compose_and_agp
branch
from
4a24d36
to
5b12b04
Compare
fabio-insolia-cko
requested review from
jheng-hao-lin-cko and
chintan-soni-cko
chintan-soni-cko
requested changes
Oct 13, 2023
chintan-soni-cko
previously approved these changes
Oct 13, 2023
jheng-hao-lin-cko
previously approved these changes
Oct 13, 2023
fabio-insolia-cko
force-pushed
the
feature/PIMOB-2191_Upgrade_kotlin_compose_and_agp
branch
from
fad2634
to
91b60f7
Compare
chintan-soni-cko
approved these changes
Oct 17, 2023
fabio-insolia-cko
deleted the
feature/PIMOB-2191_Upgrade_kotlin_compose_and_agp
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PIMOB-2191
Proposed changes
As part of the solution for this issue the scope of this ticket is to upgrade AGP, Gradle and all the other dependency
Test Steps
Run both the java and the compose app and run a smoke test to verify that the general behaviour is unchanged
Checklist